ESM Migration #40
Merged
ESM Migration #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: `WebSocketServerConfigInput` types were incorrect in `WebSocketServer` constructor fix: import of `resource-counter` library fix: consistent import of `ws` library
…utility function
|
It looks like we will be switching to DI instead of mocking for most things then... |
|
Date mocking would be complex in the keys domain of PK though, but it should still be doable, we'll cross that bridge when we get there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to complete the ESM migration of the
js-wslibrary.The biggest change is now the import synax. We now always use
.jswhen referring to any modules we want to import.Tests
When using fast-check-jest, it uses the
@jest/globalspackage, this is not supported by theswcloader. Hence we need to usepatch-packageto patch it out: swc-project/plugins#310When using swc with jest and esm, mocking behaviour is undefined. This is intended: swc-project/swc#5205
Thus all mocks have been removed in the process.
Issues Fixed
Tasks
Final checklist